Add Fake Analytics instance that uses list to save events sent #149
Conversation
| /// Use this list to check for events that have been emitted when | ||
| /// invoking the send method | ||
| final List<Event> sentEvents = []; | ||
|
|
There was a problem hiding this comment.
@bkonyi thoughts on this so far. I figured that for the fake instance, all you really need is to have access to a list that will contain each Event we send so we only really need to override the send method to add to the list
I think all other functionality within the default implementation class should be fine?
There was a problem hiding this comment.
Yeah, I think this looks good to me! Assuming each Event implementation has operator == and hashCode overrides, this will work perfectly :).
| @override | ||
| int get hashCode => eventData.hashCode; | ||
|
|
||
| @override | ||
| bool operator ==(Object other) => | ||
| other is Event && | ||
| other.runtimeType == runtimeType && | ||
| other.eventName == eventName && | ||
| compareEventData(other.eventData, eventData); |
There was a problem hiding this comment.
I've added these overrides with some tests to ensure it works correctly, but does this look good? @bkonyi
We essentially just need to check the event name and the data in the eventData map
|
@bkonyi friendly ping, lmk if you think this is good to go |
|
@christopherfujino requesting since Ben is OOO until next week, this PR looks to add a fake instance we can ship out to clients so that they can keep track of events in a list for testing purposes |
| @@ -627,6 +627,50 @@ class AnalyticsImpl implements Analytics { | |||
| } | |||
| } | |||
|
|
|||
| class FakeAnalytics extends AnalyticsImpl { | |||
There was a problem hiding this comment.
I think this should have a dartdoc explaining exactly what is different between this and AnalyticsImpl.
* support 'package:http' 2.0.0 * update changelog * update the CI SDK versions
Address issue:
This PR adds a subclass of
Analyticsthat extends the defaultAnalyticsImplimplementation and overrides the.send(Event)method.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.